On 04/28/2014 01:27 AM, Zhang Zhen wrote:
If the return number of ceph_osdc_readpages() is not
less than zero, it is certainly greater than or
equal to zero.
So the condition judgment is unnecessary.
Looks good.
Reviewed-by: Alex Elder <[email protected]>
Signed-off-by: Zhang Zhen <[email protected]>
---
fs/ceph/addr.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
index b53278c..8f579d2 100644
--- a/fs/ceph/addr.c
+++ b/fs/ceph/addr.c
@@ -221,8 +221,7 @@ static int readpage_nounlock(struct file *filp, struct page
*page)
}
SetPageUptodate(page);
- if (err >= 0)
- ceph_readpage_to_fscache(inode, page);
+ ceph_readpage_to_fscache(inode, page);
out:
return err < 0 ? err : 0;
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
