Reviewed-by: Sage Weil <[email protected]>
On Mon, 12 May 2014, Ilya Dryomov wrote:
> Commit e2b149cc4ba0 ("crush: add chooseleaf_vary_r tunable") added the
> crush_map::chooseleaf_vary_r field but missed the decode part. This
> lead to misdirected requests caused by incorrect raw crush mapping
> sets.
>
> Fixes: http://tracker.ceph.com/issues/8226
>
> Reported-and-Tested-by: Dmitry Smirnov <[email protected]>
> Signed-off-by: Ilya Dryomov <[email protected]>
> ---
> net/ceph/osdmap.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/net/ceph/osdmap.c b/net/ceph/osdmap.c
> index 8b8a5a24b223..c547e46084d3 100644
> --- a/net/ceph/osdmap.c
> +++ b/net/ceph/osdmap.c
> @@ -329,6 +329,11 @@ static struct crush_map *crush_decode(void *pbyval, void
> *end)
> dout("crush decode tunable chooseleaf_descend_once = %d",
> c->chooseleaf_descend_once);
>
> + ceph_decode_need(p, end, sizeof(u8), done);
> + c->chooseleaf_vary_r = ceph_decode_8(p);
> + dout("crush decode tunable chooseleaf_vary_r = %d",
> + c->chooseleaf_vary_r);
> +
> done:
> dout("crush_decode success\n");
> return c;
> --
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
