On Fri, 22 Aug 2014, Somnath Roy wrote: > I think it is using direct io for non-aio mode as well.
Right. aio is always direct io (in our case at least). sage > > Thanks & Regards > Somnath > > -----Original Message----- > From: Mark Kirkwood [mailto:[email protected]] > Sent: Friday, August 22, 2014 3:19 PM > To: Sage Weil > Cc: Ma, Jianpeng; Somnath Roy; Samuel Just ([email protected]); > [email protected] > Subject: Re: Deadlock in ceph journal > > On 22/08/14 12:49, Sage Weil wrote: > > On Fri, 22 Aug 2014, Mark Kirkwood wrote: > >> On 22/08/14 03:23, Sage Weil wrote: > >>> I've pushed the patch to wip-filejournal. Mark, can you test please? > >>> > >> > >> I've tested wip-filejournal and looks good (25 test runs, good > >> journal header each time). > > > > Thanks! Merged. > > > > Excellent. > > One thing that does still concern me - if I understand what is happening here > correctly: we write to the journal using aio until we want to stop doing > writes (presumably pre closing it), then use normal io to write at that point. > > Given that we appear to be using direct io whenever we use aio, does this > mean we end up mixing direct and buffered io to the journal [1] (or is the > normal i.e non aio write still using direct io)? > > Cheers > > Mark > > [1] which I understand is bad... > > ________________________________ > > PLEASE NOTE: The information contained in this electronic mail message is > intended only for the use of the designated recipient(s) named above. If the > reader of this message is not the intended recipient, you are hereby notified > that you have received this message in error and that any review, > dissemination, distribution, or copying of this message is strictly > prohibited. If you have received this communication in error, please notify > the sender by telephone or e-mail (as shown above) immediately and destroy > any and all copies of this message in your possession (whether hard copies or > electronically stored copies). > > -- > To unsubscribe from this list: send the line "unsubscribe ceph-devel" in > the body of a message to [email protected] > More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
