Ack Travis. Since it touches a dashboard, Nizam - please reply/approve.
I assume that rados/dashboard tests will be sufficient, but expecting your recommendations. This addition will make the final release likely to be pushed. On Mon, Nov 13, 2023 at 11:30 AM Travis Nielsen <tniel...@redhat.com> wrote: > > I'd like to see these changes for much improved dashboard integration with > Rook. The changes are to the rook mgr orchestrator module, and supporting > test changes. Thus, this should be very low risk to the ceph release. I don't > know the details of the tautology suites, but I would think suites involving > the mgr modules would only be necessary. > > Travis > > On Mon, Nov 13, 2023 at 12:14 PM Yuri Weinstein <ywein...@redhat.com> wrote: >> >> Redouane >> >> What would be a sufficient level of testing (tautology suite(s)) >> assuming this PR is approved to be added? >> >> On Mon, Nov 13, 2023 at 9:13 AM Redouane Kachach <rkach...@redhat.com> wrote: >> > >> > Hi Yuri, >> > >> > I've just backported to reef several fixes that I introduced in the last >> > months for the rook orchestrator. Most of them are fixes for dashboard >> > issues/crashes that only happen on Rook environments. The PR [1] has all >> > the changes and it was merged into reef this morning. We really need these >> > changes to be part of the next reef release as the upcoming Rook stable >> > version will be based on it. >> > >> > Please, can you include those changes in the upcoming reef 18.2.1 release? >> > >> > [1] https://github.com/ceph/ceph/pull/54224 >> > >> > Thanks a lot, >> > Redouane. >> > >> > >> > On Mon, Nov 13, 2023 at 6:03 PM Yuri Weinstein <ywein...@redhat.com> wrote: >> >> >> >> ---------- Forwarded message --------- >> >> From: Venky Shankar <vshan...@redhat.com> >> >> Date: Thu, Nov 9, 2023 at 11:52 PM >> >> Subject: Re: [ceph-users] Re: reef 18.2.1 QE Validation status >> >> To: Yuri Weinstein <ywein...@redhat.com> >> >> Cc: dev <d...@ceph.io>, ceph-users <ceph-users@ceph.io> >> >> >> >> >> >> Hi Yuri, >> >> >> >> On Fri, Nov 10, 2023 at 4:55 AM Yuri Weinstein <ywein...@redhat.com> >> >> wrote: >> >> > >> >> > I've updated all approvals and merged PRs in the tracker and it looks >> >> > like we are ready for gibba, LRC upgrades pending approval/update from >> >> > Venky. >> >> >> >> The smoke test failure is caused by missing (kclient) patches in >> >> Ubuntu 20.04 that certain parts of the fs suite (via smoke tests) rely >> >> on. More details here >> >> >> >> https://tracker.ceph.com/issues/63488#note-8 >> >> >> >> The kclient tests in smoke pass with other distro's and the fs suite >> >> tests have been reviewed and look good. Run details are here >> >> >> >> https://tracker.ceph.com/projects/cephfs/wiki/Reef#07-Nov-2023 >> >> >> >> The smoke failure is noted as a known issue for now. Consider this run >> >> as "fs approved". >> >> >> >> > >> >> > On Thu, Nov 9, 2023 at 1:31 PM Radoslaw Zarzynski <rzarz...@redhat.com> >> >> > wrote: >> >> > > >> >> > > rados approved! >> >> > > >> >> > > Details are here: >> >> > > https://tracker.ceph.com/projects/rados/wiki/REEF#1821-Review. >> >> > > >> >> > > On Mon, Nov 6, 2023 at 10:33 PM Yuri Weinstein <ywein...@redhat.com> >> >> > > wrote: >> >> > > > >> >> > > > Details of this release are summarized here: >> >> > > > >> >> > > > https://tracker.ceph.com/issues/63443#note-1 >> >> > > > >> >> > > > Seeking approvals/reviews for: >> >> > > > >> >> > > > smoke - Laura, Radek, Prashant, Venky (POOL_APP_NOT_ENABLE failures) >> >> > > > rados - Neha, Radek, Travis, Ernesto, Adam King >> >> > > > rgw - Casey >> >> > > > fs - Venky >> >> > > > orch - Adam King >> >> > > > rbd - Ilya >> >> > > > krbd - Ilya >> >> > > > upgrade/quincy-x (reef) - Laura PTL >> >> > > > powercycle - Brad >> >> > > > perf-basic - Laura, Prashant (POOL_APP_NOT_ENABLE failures) >> >> > > > >> >> > > > Please reply to this email with approval and/or trackers of known >> >> > > > issues/PRs to address them. >> >> > > > >> >> > > > TIA >> >> > > > YuriW >> >> > > > _______________________________________________ >> >> > > > Dev mailing list -- d...@ceph.io >> >> > > > To unsubscribe send an email to dev-le...@ceph.io >> >> > > > >> >> > > >> >> > _______________________________________________ >> >> > ceph-users mailing list -- ceph-users@ceph.io >> >> > To unsubscribe send an email to ceph-users-le...@ceph.io >> >> >> >> >> >> >> >> -- >> >> Cheers, >> >> Venky >> >> >> _______________________________________________ >> ceph-users mailing list -- ceph-users@ceph.io >> To unsubscribe send an email to ceph-users-le...@ceph.io _______________________________________________ ceph-users mailing list -- ceph-users@ceph.io To unsubscribe send an email to ceph-users-le...@ceph.io
