HI all,

i'm digging in the src code of ceph0.80.6, i think the following code in void 
Monitor::timecheck_start_round()  in moitor.cc  from line 3160 to 3168 is very 
strange,
in my opinion, the red highligted part should be    curr_time - 
timecheck_round_start < max   ,
that is if time elapsed less than max, then keep current round going, else 
cance current round.


double max = g_conf->mon_timecheck_interval*3;
if (curr_time - timecheck_round_start > max) { 
dout(10) << __func__ << " keep current round going" << dendl; 
goto out; 
} else { 
dout(10) << __func__ 
<< " finish current timecheck and start new" << dendl; 
timecheck_cancel_round(); 
} 


just my opinion, any reply is welcomed!


thanks very much



[email protected]
_______________________________________________
ceph-users mailing list
[email protected]
http://lists.ceph.com/listinfo.cgi/ceph-users-ceph.com

Reply via email to