Hi Alan, hi Toke, On Feb 15, 2015, at 17:33 , Alan Jenkins <[email protected]> wrote:
> > On 15/02/15 15:56, Toke Høiland-Jørgensen wrote: >> Sebastian Moeller <[email protected]> writes: >> >>> I am not sure that this works as intended. The first thing >>> run.sh does is take down all running SQM instances: >> Ah yes, seems I was a bit too trigger-happy there ;) > I was just about to explain the same, after testing it :). (I have more > interfaces coming up after pppoe-wan, so SQM stops immediately after it's > started) > >> Here's a version of run.sh that should also short-circuit the 'down' >> part if called from hotplug. > Yep. that version works ok. > >> The alternative is, of course, to have logic in the hotplug script to >> only call run.sh for interfaces that are enabled, but that would require >> parsing /etc/config/sqm from there. My initial thought was that >> short-circuiting the logic in run.sh was 'cleaner'; but I'm not entirely >> sure about that... Thoughts? >> >> -Toke > > It's a small tweak, but maybe the argument to run.sh could be made explicit. > > run.sh start $DEVICE # specific device > run.sh # all devices Mmmh, that sounds like a decent plan, I will see how it looks after I implemented it. Most likely I will not get around to that before next weekend though… Best Regards Sebastian > > Regards > Alan > _______________________________________________ > Cerowrt-devel mailing list > [email protected] > https://lists.bufferbloat.net/listinfo/cerowrt-devel _______________________________________________ Cerowrt-devel mailing list [email protected] https://lists.bufferbloat.net/listinfo/cerowrt-devel
