Hmm. Trying to be generous, it looks like something I might do if I tended
to have a lot of DB disconnects but didn't discover that until after I'd
written the rest. It's a hack, essentially. That doesn't really explain
the error he returns from the catch, though.
Regarding the evaluation of others' code, I generally agree with Maureen.
However, I'm willing to comment on the quality of any code I purchase. If
someone sells me a product, and the code is crap, I'm gonna squak about it
if anyone asks.
Of course, I mean that to be public evaluation. Internally (here at
Moonbow) I will review code written both by other employees and anyone we
have working relationships with. Of course, if I'm bashing someone else's
code to my boss, I'm usually trying to gently give them tips on how to
improve.
If a company you hired writes poor code, should you fire them? If they're
showing gross incompetence, yeah. If their code works, doesn't bog the
server unreasonably, and otherwise meets spec, I guess it depends on the
contract. If you have an out and feel that you would do better with another
coder, go ahead and use the out. Otherwise, you're bound unless you can
come to some sort of "gentleman's agreement" about it.
Hmm. I could say more, but I'll wait and see what other people think. :-)
-- Ben Doom
Programmer & General Lackey
Moonbow Software, Inc
: -----Original Message-----
: From: Maureen [mailto:[EMAIL PROTECTED]
: Sent: Tuesday, March 25, 2003 4:19 AM
: To: CF-Community
: Subject: Re: Best practice? CFTHROW
:
:
: At 04:32 AM 3/25/03, Michael wrote:
:
: >BTW, I posted this to community as I want a debate on this. Not only the
: >debate
: >on the use of CFTHROW in this case, but on sale of products,
: companies worth
: >buying from and the ethics of 'outing' a company that writes poor code.
:
: Well, it was poor code, very similar in style to jumping out of a loop in
: Basic with a goto. Most likely written by a beginner.
:
: The only time I comment on the quality of another company's code
: is if the
: client has hired me specifically to evaluate the code and make a
: recommendation.
:
: Which is a good thing, because I've seen so much crap code in software
: products that if I told about all of it ...well, you know.
:
: That being said, I also don't recommend products that I know contain junk
: code. I tried to steer people to a better solution without trashing the
: bad product.
:
: The worst I've ever seen was from a very large, and now very bankrupt web
: development company that charged a client 50K for a web site which was
: never completed. I was hired to evaluate the code so the client could
: decide whether to sue. For 50K, they had written 91 lines of
: code, and 12
: queries. None of it worked.
:
:
:
:
:
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~|
Archives: http://www.houseoffusion.com/cf_lists/index.cfm?forumid=5
Subscription:
http://www.houseoffusion.com/cf_lists/index.cfm?method=subscribe&forumid=5
Get the mailserver that powers this list at http://www.coolfusion.com
Unsubscribe:
http://www.houseoffusion.com/cf_lists/unsubscribe.cfm?user=89.70.5
