I worked out how to submit a review (there's a section "Submitting your review" towards the bottom of https://help.github.com/articles/reviewing-proposed-changes-in-a-pull-request/) and have approved the changes.
I was happy to do this, as it seems like convenient way for those involved in the discussion to sign it off, but I would also like to see a comment in the issue (Trac 164 in this case) saying that consensus has been reached so we can start the 3 week countdown. I'm not sure about merging this pull request into master at this time. I don't think we agreed on this procedure last week, and how best to go about merging changes is currently being discussed on github #130 @JonathanGregory The conformance work has been done, in a pull request to the Conformance repository: https://github.com/cf-convention/Conformance/pull/6/commits/f687062fbb37c94c43ad44b4b3e41dd30cd0770b?short_path=a2980ec#diff-a2980ec1fbd787c60bcc53548dd58680 (which, I realise, is interesting, as we now have two seperate pull requests for the same proposal, which do not link to each other, as far as I can see) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/cf-convention/cf-conventions/pull/115#issuecomment-399947903
