erget commented on this pull request.
Content looks fine, I've requested 2 formatting changes to be able to trace
changes better moving forward.
> @@ -433,7 +433,9 @@ to a reference direction.
| Applied to all abscissa values in the rectangular
coordinates for a map projection in order to eliminate negative numbers.
Expressed in
the unit of the coordinate variable identified by the
- standard name **`projection_x_coordinate`**.
+ standard name **`projection_x_coordinate`**. If
@neumannd could you move this sentence onto its own line (and on line 449) so
it's one sentence, one line?
In source code it makes sense to restrict line length, but for a document like
the Conventions it makes it easier to compare changes if each sentence stands
on its own line. Then a blame doesn't produce false positives. We don't need to
reflow all the text in the documents but when we touch or add a sentence I
think it's best to put them on their own line.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/cf-convention/cf-conventions/pull/225#pullrequestreview-339826572
This list forwards relevant notifications from Github. It is distinct from
[email protected], although if you do nothing, a subscription to the
UCAR list will result in a subscription to this list.
To unsubscribe from this list only, send a message to
[email protected].