@zklaus commented on this pull request.
> We recommend that the unit **`year`** be used with caution. The Udunits > package defines a **`year`** to be exactly 365.242198781 days (the interval > between 2 successive passages of the sun through vernal equinox). __It is not > a calendar year.__ Udunits includes the following definitions for years: a > **`common_year`** is 365 days, a **`leap_year`** is 366 days, a > **`Julian_year`** is 365.25 days, and a **`Gregorian_year`** is 365.2425 days. Perhaps this is a good opportunity to update the second `udunits.dat` link in the following line 217 as well. I also wonder if we should be explicit in whether CF follows udunits in the definitions of year and month. The way these two paragraphs are written, the reader might come away with the impression that we are only warning of potential misinterpretation by some other software, whereas my understanding so far is that we adopt the udunits definition, albeit begrudgingly. But perhaps my understand is wrong or you would prefer to address this in a separate issue? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://urldefense.us/v3/__https://github.com/cf-convention/cf-conventions/pull/331*pullrequestreview-698116628__;Iw!!G2kpM7uM-TzIFchu!mhPiWh-LwYmnmiQt5IEjICNGBndKP5wPsM8E2Xmrd21amAKc1zLZ3xxI2Kj_512peloWXhHqYV4$ This list forwards relevant notifications from Github. It is distinct from [email protected], although if you do nothing, a subscription to the UCAR list will result in a subscription to this list. To unsubscribe from this list only, send a message to [email protected].
