Holy hell in a hand backet Batman!
This code is clean but mostly useless. I see queries that are never used, try/catch blocks thrown in for no reason other to have them and more. Looks like I'm going to have to clean it up before I make use of it. When I'm done, Dinowitz_Debug will be a debug template using a CFTREE (yes, I think it's needed for some sites) to show the flow of templates and information. It will also provide more information about stored procedures than the current debug template does and will reorder the variable dumps.
I kind of need it now, so that's what I'm working on at the moment. Anyone have a suggestion or such, let me know.
Just as an example, the call to the factory is inside a try catch with the catch doing nothing. Then there's a bunch of queries to the factory data. All of these are in try catches with nothing in the catch. Point is, if the factory fails, you should abort the template with an error message rather than going on as all of the debug will fail. If the factory exists, then all the queries will exist (though some may return nothing). Therefore, there's no need for a try/catch around each one.
Also, queries that are never used should just be removed. Why add query overhead for no reason.
[Todays Threads] [This Message] [Subscription] [Fast Unsubscribe] [User Settings] [Donations and Support]
