Hey feedback! > 3. Possibly... I seem to recall your solution was overly complex
OK, any ideas on how to make it less complex? Which part of it did you consider to be complex and why? Some things that I did notice I could improve in the code is to use the actual variable scope instead of evaluating a string in the "getSingletonScope" method, and use some locking. > You're using DataType as both a container and the elements it contains which seems wrong. When I read up about the design pattern in Java this was the closest I could get it to the real thing. (link: http://www.javacamp.org/designPattern/enum.html ) > You also aren't explaining what problem you're trying to solve with this. I was hoping to get some feedback from people that are familiar with the design pattern, since I want to stick with the design pattern it would not be relevant to explain what it should do, as that way I might receive feedback on how to implement it some other way, but that is not what I am after. I want to stick to the pattern, thus someone who is familiar with the pattern could comment and provide feedback better than someone who does not (also, I did specify that I could provide more details if required). > Again, as with your singleton implementation, it seems unnecessarily complex. You must have had a close look at the code to make this assumption, please provide details. But as you said, maybe this is not the list to discuss this.. Thanks ;-) -- Taco Fleur Senior Web Systems Engineer http://www.webassociates.com ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~| Special thanks to the CF Community Suite Gold Sponsor - CFHosting.net http://www.cfhosting.net Message: http://www.houseoffusion.com/lists.cfm/link=i:4:189188 Archives: http://www.houseoffusion.com/cf_lists/threads.cfm/4 Subscription: http://www.houseoffusion.com/lists.cfm/link=s:4 Unsubscribe: http://www.houseoffusion.com/cf_lists/unsubscribe.cfm?user=89.70.4 Donations & Support: http://www.houseoffusion.com/tiny.cfm/54
