Well, its the template that controls a boatload of editing functionality in 
my cms. Nothing top secret or especially brilliant in it but kinda on the 
proprietary side. You can look if you like after reading the following. 
 I *know* I could shorten it up by separating out the action section at 
template top. I've got 1400 or so lines of the 2100 lines of code in that 
portion (which is loaded with tag and include calls as appropriate). Also, 
when I write code, I write vertically, by that I mean I do not write 
  <cfmodule template="tags/groupmatch.cfm" ontopic="#client.thisEditMarker#" 
UserID="#client.contentProducer#">
 I instead write it
  <cfmodule 
template="tags/groupmatch.cfm"
ontopic="#client.thisEditMarker#"
UserID="#client.contentProducer#">
  and 
 <!--- 
this is a comment.
--->
 I do put a very few tags on a single line (like cfparam) but not many. Same 
with html form fields (and there are a bunch of them there). That style adds 
a lot of lines to the count. And my SQL is along these lines:
 <cfquery 
username="#request.thisDBUserName#"
password="#request.thisDBPassword#" 
datasource="#request.thisSiteDSN#">
UPDATE 
topics_groups
SET 
topics_groups.ParentID=
<cfqueryparam 
cfsqltype="CF_SQL_NUMERIC" 
value="#Val(client.thisParent)#" 
null="#YesNoFormat(not Len(client.thisParent))#">
WHERE 
topics_groups.ParentID=
<cfqueryparam 
cfsqltype="CF_SQL_NUMERIC" 
value="#Val(client.thisEditMarker)#">
</cfquery>
 (no wisecracks about the use of client vars... gotta do that for backward 
compatibility in this particular app).
 Anyway that could be done in a LOT fewer lines, and as you can imagine an 
update of 20 fields is a couple of screenfuls. But I like writing it this 
way as part of a set of standards I always stick to, which to me are more 
readable.
 I bet if I broke all of the 14 actions into includes -- includes called in 
only one place in the app -- and switched to single-line tag calls I'd be 
within your 500-line limit.
 But I don't wanna :-)

-- 
--mattRobertson--
Janitor, MSB Web Systems
mysecretbase.com <http://mysecretbase.com>


~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~|
Discover CFTicket - The leading ColdFusion Help Desk and Trouble 
Ticket application

http://www.houseoffusion.com/banners/view.cfm?bannerid=48

Message: http://www.houseoffusion.com/lists.cfm/link=i:4:215386
Archives: http://www.houseoffusion.com/cf_lists/threads.cfm/4
Subscription: http://www.houseoffusion.com/lists.cfm/link=s:4
Unsubscribe: 
http://www.houseoffusion.com/cf_lists/unsubscribe.cfm?user=11502.10531.4
Donations & Support: http://www.houseoffusion.com/tiny.cfm/54

Reply via email to