ilovepi wrote:
I see this patch also failing its own tests in our ci
```
******************** TEST 'Clang :: Driver/DTLTO/dtlto.c' FAILED
********************
Exit Code: 1
Command Output (stderr):
--
/b/s/w/ir/x/w/llvm_build/bin/clang -flto=thin
/b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/DTLTO/dtlto.c -###
-fuse-ld=lld --target=x86_64-linux-gnu -Xthinlto-distributor=a1
-Xthinlto-distributor=a2,a3 -fthinlto-distributor=d.exe -Werror 2>&1 |
/b/s/w/ir/x/w/llvm_build/bin/FileCheck
/b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/DTLTO/dtlto.c
--check-prefix=FORWARD # RUN: at line 6
+ /b/s/w/ir/x/w/llvm_build/bin/FileCheck
/b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/DTLTO/dtlto.c
--check-prefix=FORWARD
+ /b/s/w/ir/x/w/llvm_build/bin/clang -flto=thin
/b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/DTLTO/dtlto.c -###
-fuse-ld=lld --target=x86_64-linux-gnu -Xthinlto-distributor=a1
-Xthinlto-distributor=a2,a3 -fthinlto-distributor=d.exe -Werror
/b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/DTLTO/dtlto.c:14:18: error:
FORWARD-SAME: expected string not found in input
// FORWARD-SAME: "--thinlto-distributor-arg=a1"
^
<stdin>:6:875: note: scanning from here
"/b/s/w/ir/x/w/llvm_build/bin/ld.lld" "--hash-style=gnu" "--build-id"
"--eh-frame-hdr" "-m" "elf_x86_64" "-pie" "-dynamic-linker"
"/lib64/ld-linux-x86-64.so.2" "-o" "a.out" "/lib/x86_64-linux-gnu/Scrt1.o"
"/lib/x86_64-linux-gnu/crti.o" "crtbeginS.o" "-L/lib/x86_64-linux-gnu"
"-L/lib/../lib64" "-L/usr/lib/x86_64-linux-gnu" "-L/usr/lib64" "-L/lib"
"-L/usr/lib" "-plugin-opt=mcpu=x86-64" "-plugin-opt=thinlto"
"--thinlto-distributor=d.exe"
"--thinlto-remote-compiler=/b/s/w/ir/x/w/llvm_build/bin/llvm"
"--thinlto-distributor-arg=a1" "--thinlto-distributor-arg=a2"
"--thinlto-distributor-arg=a3" "/b/s/w/ir/x/t/lit-tmp-7dk9usqs/dtlto-d79331.o"
"/b/s/w/ir/x/w/llvm_build/lib/clang/22/lib/x86_64-unknown-linux-gnu/libclang_rt.builtins.a"
"--as-needed" "-lunwind" "--no-as-needed" "-lc"
"/b/s/w/ir/x/w/llvm_build/lib/clang/22/lib/x86_64-unknown-linux-gnu/libclang_rt.builtins.a"
"--as-needed" "-lunwind" "--no-as-needed" "crtendS.o"
"/lib/x86_64-linux-gnu/crtn.o"
^
<stdin>:6:940: note: possible intended match here
"/b/s/w/ir/x/w/llvm_build/bin/ld.lld" "--hash-style=gnu" "--build-id"
"--eh-frame-hdr" "-m" "elf_x86_64" "-pie" "-dynamic-linker"
"/lib64/ld-linux-x86-64.so.2" "-o" "a.out" "/lib/x86_64-linux-gnu/Scrt1.o"
"/lib/x86_64-linux-gnu/crti.o" "crtbeginS.o" "-L/lib/x86_64-linux-gnu"
"-L/lib/../lib64" "-L/usr/lib/x86_64-linux-gnu" "-L/usr/lib64" "-L/lib"
"-L/usr/lib" "-plugin-opt=mcpu=x86-64" "-plugin-opt=thinlto"
"--thinlto-distributor=d.exe"
"--thinlto-remote-compiler=/b/s/w/ir/x/w/llvm_build/bin/llvm"
"--thinlto-distributor-arg=a1" "--thinlto-distributor-arg=a2"
"--thinlto-distributor-arg=a3" "/b/s/w/ir/x/t/lit-tmp-7dk9usqs/dtlto-d79331.o"
"/b/s/w/ir/x/w/llvm_build/lib/clang/22/lib/x86_64-unknown-linux-gnu/libclang_rt.builtins.a"
"--as-needed" "-lunwind" "--no-as-needed" "-lc"
"/b/s/w/ir/x/w/llvm_build/lib/clang/22/lib/x86_64-unknown-linux-gnu/libclang_rt.builtins.a"
"--as-needed" "-lunwind" "--no-as-needed" "crtendS.o"
"/lib/x86_64-linux-gnu/crtn.o"
^
Input file: <stdin>
Check file: /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/DTLTO/dtlto.c
-dump-input=help explains the following input dump.
Input was:
<<<<<<
1: Fuchsia clang version 22.0.0git
(https://llvm.googlesource.com/llvm-project
20b47bfdb5aee6e66d06342c275d56477371dc4e)
2: Target: x86_64-unknown-linux-gnu
3: Thread model: posix
4: InstalledDir: /b/s/w/ir/x/w/llvm_build/bin
5: "/b/s/w/ir/x/w/llvm_build/bin/llvm" "clang" "-cc1" "-triple"
"x86_64-unknown-linux-gnu" "-emit-llvm-bc" "-flto=thin" "-flto-unit" "-dumpdir"
"a-" "-disable-free" "-clear-ast-before-backend" "-disable-llvm-verifier"
"-discard-value-names" "-main-file-name" "dtlto.c" "-mrelocation-model" "pic"
"-pic-level" "2" "-pic-is-pie" "-mframe-pointer=all" "-fmath-errno"
"-ffp-contract=on" "-fno-rounding-math" "-mconstructor-aliases"
"-funwind-tables=2" "-target-cpu" "x86-64" "-tune-cpu" "generic"
"-debugger-tuning=gdb"
"-fdebug-compilation-dir=/b/s/w/ir/x/w/llvm_build/tools/clang/test/Driver/DTLTO"
"-fcoverage-compilation-dir=/b/s/w/ir/x/w/llvm_build/tools/clang/test/Driver/DTLTO"
"-resource-dir" "/b/s/w/ir/x/w/llvm_build/lib/clang/22" "-internal-isystem"
"/b/s/w/ir/x/w/llvm_build/lib/clang/22/include" "-internal-isystem"
"/usr/local/include" "-internal-externc-isystem"
"/usr/include/x86_64-linux-gnu" "-internal-externc-isystem" "/include"
"-internal-externc-isystem" "/usr/include" "-Werror" "-ferror-limit" "19"
"-fgnuc-version=4.2.1" "-fskip-odr-check-in-gmf" "-faddrsig"
"-D__GCC_HAVE_DWARF2_CFI_ASM=1" "-o"
"/b/s/w/ir/x/t/lit-tmp-7dk9usqs/dtlto-d79331.o" "-x" "c"
"/b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/DTLTO/dtlto.c"
6: "/b/s/w/ir/x/w/llvm_build/bin/ld.lld" "--hash-style=gnu"
"--build-id" "--eh-frame-hdr" "-m" "elf_x86_64" "-pie" "-dynamic-linker"
"/lib64/ld-linux-x86-64.so.2" "-o" "a.out" "/lib/x86_64-linux-gnu/Scrt1.o"
"/lib/x86_64-linux-gnu/crti.o" "crtbeginS.o" "-L/lib/x86_64-linux-gnu"
"-L/lib/../lib64" "-L/usr/lib/x86_64-linux-gnu" "-L/usr/lib64" "-L/lib"
"-L/usr/lib" "-plugin-opt=mcpu=x86-64" "-plugin-opt=thinlto"
"--thinlto-distributor=d.exe"
"--thinlto-remote-compiler=/b/s/w/ir/x/w/llvm_build/bin/llvm"
"--thinlto-distributor-arg=a1" "--thinlto-distributor-arg=a2"
"--thinlto-distributor-arg=a3" "/b/s/w/ir/x/t/lit-tmp-7dk9usqs/dtlto-d79331.o"
"/b/s/w/ir/x/w/llvm_build/lib/clang/22/lib/x86_64-unknown-linux-gnu/libclang_rt.builtins.a"
"--as-needed" "-lunwind" "--no-as-needed" "-lc"
"/b/s/w/ir/x/w/llvm_build/lib/clang/22/lib/x86_64-unknown-linux-gnu/libclang_rt.builtins.a"
"--as-needed" "-lunwind" "--no-as-needed" "crtendS.o"
"/lib/x86_64-linux-gnu/crtn.o"
same:14'0
X~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
error: no match found
same:14'1
?
possible intended match
>>>>>>
--
```
Bot:
https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-host-linux-x64/b8709270904931005265/overview
Logs:https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket/8709270904931005265/+/u/clang/tests/stdout
If this isn't trivial to fix, I'd suggest revert and reland once you've
addressed it.
https://github.com/llvm/llvm-project/pull/147265
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
