================
@@ -203,19 +203,6 @@ template <> struct 
MappingTraits<FormatStyle::BraceWrappingFlags> {
   }
 };
 
-template <> struct ScalarEnumerationTraits<FormatStyle::BracketAlignmentStyle> 
{
----------------
HazardyKnusperkeks wrote:

We have two kind of users, those who use `libFormat`, and those who use 
`clang-format`. The former ones get broken builds, when deprecating options, or 
when updating from `bool` to `enum`/`struct`, and possible warnings, when a 
`struct` gets a new member. The latter won't get broken anything (in regarding 
parsing the `.clang-format` file).

So the tricky part here is to still parse `Align`, `DontAlign`, `AlwaysBreak`, 
and `BlockIndent` and act accordingly, while the newer options override, if 
both are set (regardless of the order of the options in the file). So I think 
you need to keep the enum and read this from the file (but write only `true` 
and `false`), but the member should be a `bool`, **if** we go this way. Maybe 
wait for @owenca's opinion before using too much time on it.

https://github.com/llvm/llvm-project/pull/108332
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to