================
@@ -899,6 +933,52 @@ void CIRRecordLowering::accumulateBases(const
CXXRecordDecl *cxxRecordDecl) {
}
}
+void CIRRecordLowering::accumulateVBases() {
----------------
Andres-Salamanca wrote:
I noticed that the implementation we’re using is the one from classic CodeGen
in version 18, but it changed in version 19. It might be worth updating, since
the newer version looks shorter and cleaner:
**Version 18:**
https://github.com/llvm/llvm-project/blob/3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff/clang/lib/CodeGen/CGRecordLayoutBuilder.cpp#L670-L676
**Version 19:**
https://github.com/llvm/llvm-project/blob/cd708029e0b2869e80abe31ddb175f7c35361f90/clang/lib/CodeGen/CGRecordLayoutBuilder.cpp#L896-L901
What do you think, @andykaylor ?
https://github.com/llvm/llvm-project/pull/155534
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
