================
@@ -0,0 +1,229 @@
+#include "MDParser.h"
+#include "clang/Basic/CharInfo.h"
+#include "llvm/ADT/AllocatorList.h"
+
+namespace clang {
+namespace doc {
+namespace {
+bool isEmphasisDelimiter(char &Token) {
+  // TODO: support '_'
+  if (Token == '*')
+    return true;
+  return false;
+}
+} // namespace
+
+std::pair<std::optional<DelimiterContext>, size_t>
+MarkdownParser::processDelimiters(SmallString<64> &Line, const size_t &Origin) 
{
----------------
ilovepi wrote:

```suggestion
MarkdownParser::processDelimiters(StringRef Line, size_t Origin) {
```
I don't see you manipulating the Line, just reading from it. Also no point 
passing a size_t by const ref. Just pass by val, since you're not modifying it. 

https://github.com/llvm/llvm-project/pull/155887
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to