5chmidti wrote:

I won't have access to my machine for 2 weeks, so I can't try it out in the 
coming days, sorry. I'll see if I can do at least some review on mobile, but my 
general thoughts are in discourse.

For now: I think the documentation should be extended to explain that the AST 
is not a fixed construct, and it will change between versions (e.g., I think 
there was a nested namespace change recently). Also, we should encourage users 
to think about upstreaming checks when it makes sense

https://github.com/llvm/llvm-project/pull/131804
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to