https://github.com/jmorse commented:
This is looking good; my only remaining concern is about the use of `-O1` in a few places -- consulting the [testing guide](https://llvm.org/docs/TestingGuide.html) it really does encourage covering the smallest set of passes possible ("only run a minimal set of passes"). As you say, there are different outputs between -O0 and -O1, but is that because of a behaviour related to this feature, or is it just the normal behaviour of the compiler? If it's normal, we should remove the -O1 coverage. If there's something important (the presence / absence of the external symbol?) then we should narrow down what pass causes that behaviour and test that, rather than a full invocation of clang. https://github.com/llvm/llvm-project/pull/151818 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
