turran wrote: > Re-reading back the original description of the PR, I see there's > > > This solves many open issues, like: > > ``` > > * https://github.com/llvm/llvm-project/issues/64526 > > ``` > > though this PR doesn't quite solve this, since it (silently?) will try to fix > up the call sites with mismatching pointers. In issue 64526, I am looking > after a way to get a warning or an error at compile time for call sites that > perform casts that are unsafe specifically for Wasm. > > In other words, in production I am not sure if I would like to use > `-fwasm-fix-function-bitcasts` to "hide the problem under the rug", but I > would like to have a more focused warning to guide analysing casts that are > problematic for WebAssembly, with the intent of fixing the code of such call > sites by hand. > > Of course it is a fantastic idea to have a build option that can work on > these automatically. I am sure that some use cases will find it very useful.
Indeed. I'm aware of your particular case and have some clue on where/how to do it. It will touch other parts as it needs to modify the SemaCast.cpp and improve the WebAssemblyABIInfo. If you prefer, I can remove your issue from the description. I'll need some time to draft something, as compiling/linking/testing, at least for me, is very tedious. https://github.com/llvm/llvm-project/pull/153168 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
