Author: Timm Baeder Date: 2025-09-18T11:04:42+02:00 New Revision: 18630b0633bd550ad6675e155f42365ae42eb919
URL: https://github.com/llvm/llvm-project/commit/18630b0633bd550ad6675e155f42365ae42eb919 DIFF: https://github.com/llvm/llvm-project/commit/18630b0633bd550ad6675e155f42365ae42eb919.diff LOG: [clang] Remove Diag parameter from Expr::EvaluateKnownConstInt (#159512) If it's truly a known const int, it won't emit any diagnostics anyway. And if it did, we wouldn't notice because no call site passed something non-null. Added: Modified: clang/include/clang/AST/Expr.h clang/lib/AST/ExprConstant.cpp Removed: ################################################################################ diff --git a/clang/include/clang/AST/Expr.h b/clang/include/clang/AST/Expr.h index 3d7e674501ea0..9eb1a86931b11 100644 --- a/clang/include/clang/AST/Expr.h +++ b/clang/include/clang/AST/Expr.h @@ -715,9 +715,7 @@ class Expr : public ValueStmt { /// EvaluateKnownConstInt - Call EvaluateAsRValue and return the folded /// integer. This must be called on an expression that constant folds to an /// integer. - llvm::APSInt EvaluateKnownConstInt( - const ASTContext &Ctx, - SmallVectorImpl<PartialDiagnosticAt> *Diag = nullptr) const; + llvm::APSInt EvaluateKnownConstInt(const ASTContext &Ctx) const; llvm::APSInt EvaluateKnownConstIntCheckOverflow( const ASTContext &Ctx, diff --git a/clang/lib/AST/ExprConstant.cpp b/clang/lib/AST/ExprConstant.cpp index b2cb9e2b3c347..bea592d04c2df 100644 --- a/clang/lib/AST/ExprConstant.cpp +++ b/clang/lib/AST/ExprConstant.cpp @@ -17866,14 +17866,12 @@ bool Expr::isEvaluatable(const ASTContext &Ctx, SideEffectsKind SEK) const { !hasUnacceptableSideEffect(Result, SEK); } -APSInt Expr::EvaluateKnownConstInt(const ASTContext &Ctx, - SmallVectorImpl<PartialDiagnosticAt> *Diag) const { +APSInt Expr::EvaluateKnownConstInt(const ASTContext &Ctx) const { assert(!isValueDependent() && "Expression evaluator can't be called on a dependent expression."); ExprTimeTraceScope TimeScope(this, Ctx, "EvaluateKnownConstInt"); EvalResult EVResult; - EVResult.Diag = Diag; EvalInfo Info(Ctx, EVResult, EvaluationMode::IgnoreSideEffects); Info.InConstantContext = true; _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
