================
@@ -6113,9 +6113,13 @@ void Clang::ConstructJob(Compilation &C, const JobAction 
&JA,
   if (KernelOrKext && RawTriple.isOSDarwin())
     CmdArgs.push_back("-fforbid-guard-variables");
 
-  if (Args.hasFlag(options::OPT_mms_bitfields, options::OPT_mno_ms_bitfields,
-                   Triple.isWindowsGNUEnvironment())) {
-    CmdArgs.push_back("-mms-bitfields");
+  if (Args.hasArg(options::OPT_mms_bitfields) ||
----------------
mstorsjo wrote:

I've rebased the branch on top of git main as of yesterday in 
https://github.com/mstorsjo/llvm-project/commits/gcc-struct-rebased, and 
attempted to address @MaskRay's concern here.

As we have all the discussion in context here, and we already have an approval 
on this PR, it would be nice to keep it here. People with write rights to the 
repo also should be able to update the branch that this PR is based on. So as 
it seems @DanShaders doesn't mind, I guess I could push my rebased version of 
the branch there.

https://github.com/llvm/llvm-project/pull/71148
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to