https://github.com/tblah approved this pull request.
As nobody objected to the RFC, I think it is okay to follow clang doing this. Tentatively LGTM. Personally I would only really accept this as a warning for advisory flags where the expectation isn't for the the compiler to definately do as it is advised. Something like "unroll-all-loops" sounds like something that shouldn't be optional for the compiler and so I would prefer to generate an error. But in this particular case we are following clang's long established example so I guess it is okay. Please don't merge immediately in case having an approval on this nudges more people to look at the RFC. Perhaps waiting approximately a week would be sensible. https://github.com/llvm/llvm-project/pull/165579 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
