Author: Aiden Grossman Date: 2025-11-26T00:56:44Z New Revision: 4cfbc44ebe26692c209655c37aeb0b6cbf1d479b
URL: https://github.com/llvm/llvm-project/commit/4cfbc44ebe26692c209655c37aeb0b6cbf1d479b DIFF: https://github.com/llvm/llvm-project/commit/4cfbc44ebe26692c209655c37aeb0b6cbf1d479b.diff LOG: Revert "[clangd] Enable lit internal shell by default" This reverts commit c51c382c8752e7ba5049ed3662fefb9ffe9283c3. This breaks at least one buildbot: 1. https://lab.llvm.org/buildbot/#/builders/134/builds/30460 Added: Modified: clang-tools-extra/clangd/test/lit.cfg.py Removed: ################################################################################ diff --git a/clang-tools-extra/clangd/test/lit.cfg.py b/clang-tools-extra/clangd/test/lit.cfg.py index afecb593de3d3..8ab4309e337d1 100644 --- a/clang-tools-extra/clangd/test/lit.cfg.py +++ b/clang-tools-extra/clangd/test/lit.cfg.py @@ -1,26 +1,13 @@ -import os - import lit.llvm lit.llvm.initialize(lit_config, config) lit.llvm.llvm_config.clang_setup() lit.llvm.llvm_config.use_default_substitutions() -# TODO: Consolidate the logic for turning on the internal shell by default for all LLVM test suites. -# See https://github.com/llvm/llvm-project/issues/106636 for more details. -# -# We prefer the lit internal shell which provides a better user experience on failures -# and is faster unless the user explicitly disables it with LIT_USE_INTERNAL_SHELL=0 -# env var. -use_lit_shell = True -lit_shell_env = os.environ.get("LIT_USE_INTERNAL_SHELL") -if lit_shell_env: - use_lit_shell = lit.util.pythonize_bool(lit_shell_env) - config.name = "Clangd" config.suffixes = [".test"] config.excludes = ["Inputs"] -config.test_format = lit.formats.ShTest(not use_lit_shell) +config.test_format = lit.formats.ShTest(not lit.llvm.llvm_config.use_lit_shell) config.test_source_root = config.clangd_source_dir + "/test" config.test_exec_root = config.clangd_binary_dir + "/test" _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
