llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang-tools-extra Author: mitchell (zeyi2) <details> <summary>Changes</summary> Closes #<!-- -->169166 --- Full diff: https://github.com/llvm/llvm-project/pull/170034.diff 3 Files Affected: - (modified) clang-tools-extra/clang-tidy/readability/RedundantTypenameCheck.cpp (+4-2) - (modified) clang-tools-extra/docs/ReleaseNotes.rst (+4) - (modified) clang-tools-extra/test/clang-tidy/checkers/readability/redundant-typename.cpp (+14) ``````````diff diff --git a/clang-tools-extra/clang-tidy/readability/RedundantTypenameCheck.cpp b/clang-tools-extra/clang-tidy/readability/RedundantTypenameCheck.cpp index a4edd2b46b86b..feb09086f3cfd 100644 --- a/clang-tools-extra/clang-tidy/readability/RedundantTypenameCheck.cpp +++ b/clang-tools-extra/clang-tidy/readability/RedundantTypenameCheck.cpp @@ -47,8 +47,10 @@ void RedundantTypenameCheck::check(const MatchFinder::MatchResult &Result) { const SourceLocation ElaboratedKeywordLoc = [&] { if (const auto *NonDependentTypeLoc = Result.Nodes.getNodeAs<TypeLoc>("nonDependentTypeLoc")) { - if (const auto TL = NonDependentTypeLoc->getAs<TypedefTypeLoc>()) - return TL.getElaboratedKeywordLoc(); + if (const auto TL = NonDependentTypeLoc->getAs<TypedefTypeLoc>()) { + if (!TL.getType()->isDependentType()) + return TL.getElaboratedKeywordLoc(); + } if (const auto TL = NonDependentTypeLoc->getAs<TagTypeLoc>()) return TL.getElaboratedKeywordLoc(); diff --git a/clang-tools-extra/docs/ReleaseNotes.rst b/clang-tools-extra/docs/ReleaseNotes.rst index a6f80e3721db1..19c5db0ac08be 100644 --- a/clang-tools-extra/docs/ReleaseNotes.rst +++ b/clang-tools-extra/docs/ReleaseNotes.rst @@ -547,6 +547,10 @@ Changes in existing checks <clang-tidy/checks/readability/qualified-auto>` check by adding the option `IgnoreAliasing`, that allows not looking at underlying types of type aliases. +- Improved :doc:`readability-redundant-typename + <clang-tidy/checks/readability/redundant-typename>` check to correctly + handle dependent types in type aliases. + - Improved :doc:`readability-uppercase-literal-suffix <clang-tidy/checks/readability/uppercase-literal-suffix>` check to recognize literal suffixes added in C++23 and C23. diff --git a/clang-tools-extra/test/clang-tidy/checkers/readability/redundant-typename.cpp b/clang-tools-extra/test/clang-tidy/checkers/readability/redundant-typename.cpp index 2efafd1a9a649..35e239bf5694d 100644 --- a/clang-tools-extra/test/clang-tidy/checkers/readability/redundant-typename.cpp +++ b/clang-tools-extra/test/clang-tidy/checkers/readability/redundant-typename.cpp @@ -267,3 +267,17 @@ WHOLE_TYPE_IN_MACRO Macro2; #define WHOLE_DECLARATION_IN_MACRO typename NotDependent::R Macro3 WHOLE_DECLARATION_IN_MACRO; + +template<typename T> struct ListWrapper {}; +template<typename T> +class ClassWrapper { +public: + using Argument = ListWrapper<T>; + ListWrapper<Argument> arguments; + ListWrapper<Argument> getArguments() const; +}; +template<typename T> +ListWrapper<typename ClassWrapper<T>::Argument> ClassWrapper<T>::getArguments() const { + return arguments; +} +// CHECK-NOT: warning: redundant 'typename' [readability-redundant-typename] `````````` </details> https://github.com/llvm/llvm-project/pull/170034 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
