Re: [cfe-commits] r54339 - in /cfe/trunk: Driver/PrintParserCallbacks.cpp include/clang/AST/Attr.h include/clang/Parse/Action.h lib/Parse/MinimalAction.cpp lib/Parse/ParseDecl.cpp lib/Parse/ParseObjc.cpp lib/Parse/Parser.cpp lib/Sema/Sema.h lib/Sema/SemaDecl.cpp lib/Sema/SemaDeclCXX.cpp

[Argiris Kirtzidis]

Hi Daniel,

Daniel Dunbar wrote:
> Author: ddunbar
> Date: Mon Aug  4 20:35:17 2008
> New Revision: 54339
>
> URL: http://llvm.org/viewvc/llvm-project?rev=54339&view=rev
> Log:
> Add more Parser/Sema support for GCC asm-label extension.
>  - ActOnDeclarator now takes an additional parameter which is the
>    AsmLabel if used. Its unfortunate that this bubbles up this high,
>    but we cannot just lump it in as an attribute without mistakenly
>    *accepting* it as an attribute.
>   

Wouldn't it be better if "ExprTy *AsmLabel" was part of the Declarator 
class, instead of an extra parameter of ActOnDeclarator ?
I think it's slightly better conceptually to have Declarator encapsulate 
all the information about declarators, and avoid passing the info as 
separate parameters.


-Argiris
_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits