On Oct 24, 2008, at 2:38 PM, Daniel Dunbar wrote:
On Fri, Sep 26, 2008 at 2:18 PM, Chris Lattner <[EMAIL PROTECTED]>
wrote:
+ /// Characteristic_t - This is used to represent whether a file
or directory
+ /// holds normal user code, system code, or system code which is
implicitly
+ /// 'extern "C"' in C++ mode. Entire directories can be tagged
with this
+ /// (this is maintained by DirectoryLookup and friends) as can
specific
+ /// FileIDInfos when a #pragma system_header is seen or various
other cases.
+ ///
+ enum Characteristic_t {
+ C_User, C_System, C_ExternCSystem
+ };
+
Why Characteristic_t? Do we have any precedent for this naming
convention?
Lately I find myself wishing we had some more style guidelines,
clang has a rich diversity of naming conventions in it. ;)
I don't really want to start a discussion of what is best, I just
want things to be self consistent.
You're right, that was a horrible name. I renamed it to
'CharacteristicKind'. We use 'Kind' as the general suffix for enum
discriminators.
-Chris
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
