On Oct 29, 2008, at 9:22 PM, Chris Lattner wrote:

On Oct 29, 2008, at 11:41 AM, Ted Kremenek wrote:

Author: kremenek
Date: Wed Oct 29 13:41:34 2008
New Revision: 58392

URL: http://llvm.org/viewvc/llvm-project?rev=58392&view=rev
Log:
Fix crash reported in PR2923 where a function declared using typeof(another_function) would have FunctionDecl::getNumParams() return the number of parameters in the original function type and not the number of parameters in the actual FunctionDecl.

Cool, thanks for working on this Ted. There was a very similar case for C++. I thought the fix there was to actually create the parameter decls in cases like this, I think we should do everything possible to keep C++ and C consistent here.

-Chris


I wasn't aware of the similar fix for C++.

In my mind do we want to create fake ParmVarDecls here? There aren't really any decls in the prototype of the function using "typeof".
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to