Douglas Gregor wrote:
>    
> +  /// ActOnConversionFunctionExpr - Parse a C++ conversion function
> +  /// name (e.g., operator void const *) as an expression. This is
> +  /// very similar to ActOnIdentifierExpr, except that instead of
> +  /// providing an identifier the parser provides the type of the
> +  /// conversion function.
> +  virtual ExprResult ActOnConversionFunctionExpr(Scope *S, 
> +                                                 SourceLocation OperatorLoc,
> +                                                 TypeTy *Type,
> +                                                 bool HasTrailingLParen,
> +                                                 const CXXScopeSpec *SS = 0) 
> {
> +    return 0;
> +  }
> +
>   

I think it's better to change

const CXXScopeSpec *SS = 0

to

const CXXScopeSpec &SS


The former is useful when the action method is called from parts of the parser 
that the C++ front-end doesn't reach (C-only/ObjC), but this method is C++ 
specific so the latter is preferable.

BTW, should we follow the convention that all C++ specific actions have the 
'CXX' prefix ? (in this case should that be
ActOnCXXConversionFunctionExpr ?)

-Argiris


_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to