On Nov 19, 2008, at 11:24 PM, Chris Lattner wrote:

>>
>>
>> +    if (L)
>> +      return !L->isPragmaLexer();
>> +    else
>> +      return P != 0;
>
> How about:
>  return P != 0 || !L->isPragmaLexer(); ?

That's logically not the same thing.  If 'L' is non-null then 'P' is  
non-null ('P' will be an alias for 'L'), so testing for 'P != 0' first  
would return true in all cases where 'L' is non-null, not just the  
cases where !L->isPragmaLexer().
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to