On Nov 19, 2008, at 11:36 PM, Chris Lattner wrote: > > On Nov 19, 2008, at 2:21 PM, Ted Kremenek wrote: > >> Author: kremenek >> Date: Wed Nov 19 16:21:33 2008 >> New Revision: 59668 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=59668&view=rev >> Log: >> When using a PTHLexer, use DiscardToEndOfLine() instead of >> ReadToEndOfLine(). > > This isn't right for two reasons: > > 1) "#warning foo" should work with PTH. > 2) "#warning la'la" should be handled correctly, even though "'la" > is not a valid token. > > I suggest removing the 'CurPTHLexer->DiscardToEndOfLine();' and > making it an assert(0) FIXME. We'll need to introduce a new token > type for this, and have the PTH generation phase handle this > specially. > > -Chris >
I never intended it to be a permanent solution, but putting a hard assert is probably the better answer so we don't forget about it. _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
