Re: [cfe-commits] r60906 - in /cfe/trunk: include/clang/Parse/Parser.h lib/Parse/ParseDecl.cpp lib/Parse/ParseExpr.cpp lib/Parse/ParseExprCXX.cpp lib/Parse/ParseInit.cpp lib/Parse/ParseObjc.cpp lib/Parse/Parser.cpp

[Chris Lattner]

On Dec 11, 2008, at 2:52 PM, Sebastian Redl wrote:

> Author: cornedbee
> Date: Thu Dec 11 16:51:44 2008
> New Revision: 60906
>
> URL: http://llvm.org/viewvc/llvm-project?rev=60906&view=rev
> Log:
> Convert a big bunch of expression parsers to use smart pointers.

Nice!

>   //
>   switch (Tok.getKind()) {
>   default:
> -    return Diag(Tok, diag::err_expected_unqualified_id);
> +    return ExprError(Diag(Tok, diag::err_expected_unqualified_id));

Would it be possible to change Diag somehow to eliminate the need for  
the explicit ExprError syntax?

-Chris
_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits