Hi Chris, thanks for the feedback,
On 22 Jan 2009, at 05:26, Chris Lattner wrote:
Please don't use tabs.
Ooops. I have expandtabs set by default on the other machine I do LLVM hacking on - I forgot I didn't on this one.
Also, please use if (x == 0) instead of if (0 == x).
Changed.
Please declare SelectorTy as llvm::PointerType since it always must be a pointer.
Done. I've also changed the other pointer types to be PointerTypes and integer types to be IntegerTypes. This removes all of the casts to types that are not part of an initialization.
I've tested this both with the gmake test and by compiling the helper file I use for the Smalltalk compiler, which links against Objective-C code compiled with GCC. There is only one failure in CodeGen, and I don't think it's related to this (CodeGen/mmintrin-test.c - seems to be due to differences between the Darwin and FreeBSD headers - possibly this test should be replaced with a preprocessed version?)
Also, as a separate patch I see you use " (*iter).sec" in other parts of the code, please convert these to iter->sec.
Will do. This was a work around for a bug somewhere in LLVM that has now been fixed.
David
clang.diff
Description: Binary data
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
