On Wed, Feb 18, 2009 at 3:02 PM, Chris Lattner <[email protected]> wrote: > > On Feb 18, 2009, at 2:52 PM, Daniel Dunbar wrote: > >> Author: ddunbar >> Date: Wed Feb 18 16:52:09 2009 >> New Revision: 64969 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=64969&view=rev >> Log: >> Add anti-FIXME. > > I don't see how your comment is related. We should never stick mangled > names into the preprocessor's identifier table.
It is related because if we had such a notion, we would use it as the key instead of an identifier. This completely avoids any relation of mangling to how globals are emitted. - Daniel > -Chris > >> >> >> Modified: >> cfe/trunk/lib/CodeGen/CodeGenModule.cpp >> >> Modified: cfe/trunk/lib/CodeGen/CodeGenModule.cpp >> URL: >> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CodeGenModule.cpp?rev=64969&r1=64968&r2=64969&view=diff >> >> >> ============================================================================== >> --- cfe/trunk/lib/CodeGen/CodeGenModule.cpp (original) >> +++ cfe/trunk/lib/CodeGen/CodeGenModule.cpp Wed Feb 18 16:52:09 2009 >> @@ -162,7 +162,10 @@ >> /// FIXME: Returning an IdentifierInfo* here is a total hack. We >> /// really need some kind of string abstraction that either stores a >> /// mangled name or stores an IdentifierInfo*. This will require >> -/// changes to the GlobalDeclMap, too. >> +/// changes to the GlobalDeclMap, too. (I disagree, I think what we >> +/// actually need is for Sema to provide some notion of which Decls >> +/// refer to the same semantic decl. We shouldn't need to mangle the >> +/// names and see what comes out the same to figure this out. - DWD) >> /// >> /// FIXME: Performance here is going to be terribly until we start >> /// caching mangled names. However, we should fix the problem above >> >> >> _______________________________________________ >> cfe-commits mailing list >> [email protected] >> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > > _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
