On Mar 2, 2009, at 11:58 AM, Anders Carlsson wrote: > Author: andersca > Date: Mon Mar 2 13:58:15 2009 > New Revision: 65866 > > URL: http://llvm.org/viewvc/llvm-project?rev=65866&view=rev > Log: > inline asm calls should be nounwind. Chris, please review.
looks good, how about using Result->setDoesNotThrow(); though? -Chris > > > Modified: > cfe/trunk/lib/CodeGen/CGStmt.cpp > > Modified: cfe/trunk/lib/CodeGen/CGStmt.cpp > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGStmt.cpp?rev=65866&r1=65865&r2=65866&view=diff > > = > = > = > = > = > = > = > = > ====================================================================== > --- cfe/trunk/lib/CodeGen/CGStmt.cpp (original) > +++ cfe/trunk/lib/CodeGen/CGStmt.cpp Mon Mar 2 13:58:15 2009 > @@ -1003,7 +1003,10 @@ > llvm::InlineAsm *IA = > llvm::InlineAsm::get(FTy, AsmString, Constraints, > S.isVolatile() || S.getNumOutputs() == 0); > - llvm::Value *Result = Builder.CreateCall(IA, Args.begin(), > Args.end(), ""); > + llvm::CallInst *Result > + = Builder.CreateCall(IA, Args.begin(), Args.end(), ""); > + Result->addAttribute(~0, llvm::Attribute::NoUnwind); > + > if (ResultAddr) // FIXME: volatility > Builder.CreateStore(Result, ResultAddr); > } > > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
