Another review where, from my perspective, the patch itself never made it to the mailing list - is this just another case of starting a review, then adding the mailing list to the review?
>From inspection of http://reviews.llvm.org/D4327 it looks like (maybe?) the cfe-commits list was added when the review was created (at least at the same timestamp), so I'm not sure why the initial mailing wouldn't've reached the mailing list/my inbox. On Sun, Jun 29, 2014 at 12:43 PM, Daniel Jasper <[email protected]> wrote: > Looks good. > > ================ > Comment at: include/clang/ASTMatchers/ASTMatchers.h:689 > @@ -688,3 +688,3 @@ > /// \endcode > /// initList() > /// matches "{ 1, 2 }" and "{ 5, 6 }" > ---------------- > While you are here, can you replace "initList()" with "initListExpr()"? > > ================ > Comment at: include/clang/ASTMatchers/ASTMatchers.h:701 > @@ +700,3 @@ > +/// \endcode > +/// initList() > +/// matches "N" in the right-hand side of "static const int n = N;" > ---------------- > Replace initList() with the correct matcher. > > http://reviews.llvm.org/D4327 > > > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
