The patch is neat though, certainly let's reconsider pulling it in if more requests come in for this quirk in future.

Alp.


On 30/06/2014 22:34, Reid Kleckner wrote:
Yeah, let's drop it.  Sorry for the runaround.


On Mon, Jun 30, 2014 at 8:26 AM, Ehsan Akhgari <[email protected] <mailto:[email protected]>> wrote:

    We hit this error in our code and I have since fixed the code on
    our side.  I'm not aware of any system headers or generate code
    that hits this.

    Based on that, should we can this patch?

    --
    Ehsan
    <http://ehsanakhgari.org/>


    On Sat, Jun 28, 2014 at 2:07 PM, Reid Kleckner <[email protected]
    <mailto:[email protected]>> wrote:

        I'd echo what David said, but otherwise, this seems fine.

        ================
        Comment at: lib/Sema/SemaDecl.cpp:3290
        @@ +3289,3 @@
        +    Diag(SS.getBeginLoc(),
        +         getLangOpts().MicrosoftExt ?
        + diag::ext_standalone_class_nested_name_specifier :
        ----------------
        We use LangOpts.MSVCCompat to control these language bending
        extensions.

        http://reviews.llvm.org/D4333






_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

--
http://www.nuanti.com
the browser experts

_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to