On Mon, Jun 30, 2014 at 1:31 PM, Alp Toker <[email protected]> wrote: > LGTM > > BTW Ehsan, your mail looks like a reply to itself and doesn't reference my > Message-Id for threading, nor is the To or CC addressed to me in any way so > I had no way of knowing you replied other than spotting it on the list > archive. >
Sorry. I just uploaded a new patch to reviews.llvm.org. That is where the mail comes from as you've found out! Thanks for the review. -- Ehsan <http://ehsanakhgari.org/> > Manuel, could you update the website-based review guideline to indicate > that submitters should include on-list reviewers in their replies? > > Alp. > > > > > On 30/06/2014 22:55, Ehsan Akhgari wrote: > >> Moved the test. >> >> http://reviews.llvm.org/D4350 >> >> Files: >> lib/Frontend/InitPreprocessor.cpp >> test/Preprocessor/predefined-macros.c >> >> Index: lib/Frontend/InitPreprocessor.cpp >> =================================================================== >> --- lib/Frontend/InitPreprocessor.cpp >> +++ lib/Frontend/InitPreprocessor.cpp >> @@ -433,7 +433,7 @@ >> // Initialize language-specific preprocessor defines. >> // Standard conforming mode? >> - if (!LangOpts.GNUMode) >> + if (!LangOpts.GNUMode && !LangOpts.MSVCCompat) >> Builder.defineMacro("__STRICT_ANSI__"); >> if (LangOpts.CPlusPlus11) >> Index: test/Preprocessor/predefined-macros.c >> =================================================================== >> --- test/Preprocessor/predefined-macros.c >> +++ test/Preprocessor/predefined-macros.c >> @@ -9,6 +9,7 @@ >> // CHECK-MS: #define _M_IX86_FP >> // CHECK-MS: #define _WIN32 1 >> // CHECK-MS-NOT: #define __GNUC__ >> +// CHECK-MS-NOT: #define __STRICT_ANSI__ >> // >> // RUN: %clang_cc1 %s -E -dM -ffast-math -o - \ >> // RUN: | FileCheck %s --check-prefix=CHECK-FAST-MATH >> >> >> _______________________________________________ >> cfe-commits mailing list >> [email protected] >> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits >> > > -- > http://www.nuanti.com > the browser experts > >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
