================
Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:278
@@ -270,1 +277,3 @@
+ if (CheckName.empty()) {
+ switch (DiagLevel) {
----------------
Daniel Jasper wrote:
> So, this is true if Context.getCheckName(Info.getID()) returns "", right? In
> which cases does this happen?
Context.getCheckName returns non-empty string iff the diagnostic was generated
using Context.diag, i.e. for all clang-tidy diagnostics. Compiler diagnostics
may have warning option, which will be returned by getWarningOptionForDiag. If
a compiler diagnostic doesn't have a warning option, CheckName remains empty.
This is (almost?) always true for compiler errors (except for the ones mapped
with -Werror). I've added a comment to the code to clarify this a bit.
================
Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:296
@@ -273,2 +295,3 @@
DiagLevel == DiagnosticsEngine::Fatal) {
+ // Don't mute Clang errors regardless of filters and non-user code.
Level = ClangTidyError::Error;
----------------
Daniel Jasper wrote:
> nit: "Don't mute" does not seem to be exactly what this does. It seems to be
> more of a "Force reporting of".
Done.
http://reviews.llvm.org/D4356
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
