================
Comment at: CMakeLists.txt:104
@@ -103,2 +103,3 @@
option(LIBCXXABI_ENABLE_WERROR "Fail and stop if a warning is triggered." OFF)
-option(LIBCXXABI_ENABLE_SHARED "Build libc++abi as a shared library." OFF)
+option(LIBCXXABI_ENABLE_SHARED "Build libc++abi as a shared library." ON)
+
----------------
Saleem Abdulrasool wrote:
> Did you intend to make this shared by default?
Yes. See the long part of the summary. I'm willing to change this back to the
way it was if people think that's better.
================
Comment at: CMakeLists.txt:110
@@ +109,3 @@
+ else()
+ set(LIBCXXABI_LIBCXX_INCLUDES "${LLVM_INCLUDE_DIR}/c++/v1")
+ endif()
----------------
Saleem Abdulrasool wrote:
> I think that you should use a separate variable (LIBCXX_INCLUDE_DIR perhaps?)
> that is set to ${CMAKE_CURRENT_BINARY_DIR}/include rather than relying on
> LLVM's variable.
>
> I realize that this is a standalone build, and therefore LLVM_INCLUDE_DIR
> *should* point to the same location, but it makes it something that you need
> to reason out (at least, I had to think about it for a moment).
I don't understand. ${CMAKE_CURRENT_BINARY_DIR}/include won't contain the
libcxx headers...
================
Comment at: test/lit.cfg:1
@@ +1,2 @@
+# -*- Python -*- vim: set syntax=python tabstop=4 expandtab cc=80:
+
----------------
Saleem Abdulrasool wrote:
> Is this the format that the rest of the python code in LLVM uses? I don't
> really care at the end of the day, just curious.
I assumed it was. I copied it from libcxx/test/lit.cfg. I'll look in to it.
As a somewhat related note, there's a lot of redundancy between here and the
lit.cfg in libcxx. It'd be nice to factor that out at some point...
http://reviews.llvm.org/D4414
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
