This looks good to me, but you should probably wait for Marshall to take a
look. It would be nice if you took care of the nits (fwiw, I hate trailing
comments on the ifdefs since they are easy to get out of sync).
================
Comment at: include/__locale:350
@@ -343,3 +349,3 @@
static const mask blank = _BLANK;
-#elif defined(__APPLE__) || defined(__FreeBSD__) || defined(__EMSCRIPTEN__) ||
defined(__NetBSD__)
+#elif defined(__APPLE__) || defined(__FreeBSD__) || defined(__EMSCRIPTEN__) ||
defined(__NetBSD__) || defined(__ANDROID__)
#ifdef __APPLE__
----------------
Might be nice to clang-format this line.
================
Comment at: include/locale:198
@@ -197,3 +197,3 @@
#include <nl_types.h>
#endif // !_LIBCPP_MSVCRT
----------------
This is no longer very precise (not that it was particularly so before your
change).
================
Comment at: include/locale:3678
@@ -3677,3 +3677,3 @@
return -1;
#else // _WIN32
catalog __cat = (catalog)catopen(__nm.c_str(), NL_CAT_LOCALE);
----------------
Update the trailing comment.
================
Comment at: include/locale:3693
@@ -3692,3 +3692,3 @@
return __dflt;
#else // _WIN32
string __ndflt;
----------------
Same.
================
Comment at: src/locale.cpp:35
@@ -34,3 +34,3 @@
#include <langinfo.h>
#endif // !_LIBCPP_MSVCRT
#include <stdlib.h>
----------------
Same.
http://reviews.llvm.org/D4444
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
