On Thu, Jul 10, 2014 at 12:29 PM, Ulrich Weigand <[email protected]> wrote: > David Blaikie <[email protected]> wrote on 10.07.2014 20:50:55: > >> This test case relies on named IR values (%x, etc) which are not >> present (all IR values are simply numbered) in non-asserts builds of >> LLVM. I've marked the test case as "REQUIRES: asserts" for now, which >> should hopefully cause this test not to run in a non-asserts build and >> thus not fail, but it'd be good if you could go back and update the >> test by adding regex matches to ignore/match on whatever the value >> names are, rather than hardcoding them into the test. Then the >> REQUIRES line can be removed. > > Oops, I wasn't aware of that. Sorry for the breakage.
No worries - it's not obvious & everyone makes this mistake at least once, if not repeatedly. It's easy to fix when it comes up. > > I've now updated the test to use regexes like the other va_arg tests, > and verified that it passed in both an assert and a non-assert build. > > I've also removed the "REQUIRES: asserts" again. > > Checked in as r212757. Thanks! - Dave _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
