On 14 July 2014 00:52, Saleem Abdulrasool <[email protected]> wrote: > On Sun, Jul 13, 2014 at 9:17 AM, Yi Kong <[email protected]> wrote: >> >> Author: kongyi >> Date: Sun Jul 13 11:17:30 2014 >> New Revision: 212909 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=212909&view=rev >> Log: >> Add test cases for AArch64 hints codegen >> >> Modified: >> cfe/trunk/test/CodeGen/builtins-arm64.c > > > I am a bit confused by this change. What does SVN r212890 miss in terms of > testing? test/CodeGen/arm_acle.c already covers all of these, doesn't it?
CodeGen/builtins-arm64.c tests if the built-in intrinsic generates the correct LLVM IR, and CodeGen/arm_acle.c tests whether the ACLE header is correctly implemented. If hints are changed to use inline asm instead in arm_acle.h, then there will be no test case covering codegen for the intrinsic, and the developer might not realize that. Therefore although they test more or less the same thing, it would be safer to test them both. -Yi _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
