On 15/07/2014 21:01, Argyrios Kyrtzidis wrote:
On Jul 6, 2014, at 3:35 PM, Alp Toker <[email protected]> wrote:
Hi Fariborz,
As far as I can tell the original CI is immutable at this point, so changing it
isn't needed or desirable at this point. OK to remove this line? No change in
test results.
Looks like arcmt::ModifyAction will modify the original CI so that after the
file is modified in-place it will be built with ARC enabled.
Why do you need the change ?
It came up when validating LangOptions reference counting:
origCI.getLangOpts()->ObjCAutoRefCount = true;
In library usage I believe the LangOpts can have multiple owners, yet
it's modified directly here which potentially affects unrelated
compilations.
I've been hoping that this line might simply be a leftover superseded by
some other mechanism, given it has no effect on test results. if it's
still valid, do you have a test you could check in to get coverage?
Alp.
--
http://www.nuanti.com
the browser experts
<ObjCAutoRefCount.patch>_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
--
http://www.nuanti.com
the browser experts
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
