One inline comment.

Also, I'm seeing tests for -mtune and -mcpu, but very few for -march= behavior. 
Can you make some of those similar to the -mcpu ones to make sure both ways 
work?

Thanks!

================
Comment at: lib/Driver/Tools.cpp:1530
@@ +1529,3 @@
+                                  std::vector<const char *> &Features) {
+  SmallVector<StringRef, 8> Splited;
+  text.split(Splited, StringRef("+"), -1, false);
----------------
Same comment as last time. Split or Splitted. I'd prefer the first.

http://reviews.llvm.org/D4346



_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to