On Wed, Jul 16, 2014 at 3:55 PM, jahanian <[email protected]> wrote: > > On Jul 16, 2014, at 10:22 AM, Aaron Ballman <[email protected]> wrote: > > U<"objc_runtime_name">]; > + let Subjects = SubjectList<[ObjCInterface, ObjCProtocol], ErrorDiag, > + "ExpectedObjectiveCInterfaceOrProtocol">; > > > Do you think there will be more attributes appertaining to interfaces > and protocols in the future, or is that a rare combination? > > > Can’t answer that. Always on the safe side there will be more in the future.
Okay, I think the better approach is to solve this in ClangAttrEmitter.cpp, but that's something I can do. > > + let Args = [StringArgument<"MetadataName", 1>]; > > > This does not appear to be optional according to what's happen in > SemaDeclAttr.cpp (and the tests). Is that a bug here, or elsewhere? > > > Thanks for the catch. It is not optional. > > Along with the rest of your feed back in r213185 Great, thanks! ~Aaron _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
