Yup, this is needed because the TypoExpr generally isn't transformed until well after the function which provided an appropriate callback would have gone out of scope, and the TypoCorrectionConsumer isn't called upon to provide correction candidates that pass any validation the callback performs until the TypoExpr is transformed.
On Fri, Jul 25, 2014 at 1:58 PM, Richard Smith <[email protected]> wrote: > Looks fine as a mechanical change; if the final approach to ownership > needs this, then LGTM. > > > 2014-07-14 16:55 GMT-07:00 Kaelyn Takata <[email protected]>: > >> --- >> include/clang/Parse/Parser.h | 5 ++-- >> include/clang/Sema/Sema.h | 27 +++++++++---------- >> include/clang/Sema/SemaInternal.h | 18 ++++++------- >> lib/Parse/ParseExpr.cpp | 8 +++--- >> lib/Parse/ParseStmt.cpp | 6 ++--- >> lib/Parse/ParseTentative.cpp | 8 +++--- >> lib/Parse/Parser.cpp | 8 +++--- >> lib/Sema/SemaCXXScopeSpec.cpp | 9 +++---- >> lib/Sema/SemaDecl.cpp | 57 >> +++++++++++++++++++-------------------- >> lib/Sema/SemaDeclCXX.cpp | 27 ++++++++++--------- >> lib/Sema/SemaDeclObjC.cpp | 21 +++++++-------- >> lib/Sema/SemaExpr.cpp | 37 ++++++++++++------------- >> lib/Sema/SemaExprMember.cpp | 15 +++++------ >> lib/Sema/SemaExprObjC.cpp | 18 ++++++------- >> lib/Sema/SemaInit.cpp | 4 +-- >> lib/Sema/SemaLambda.cpp | 4 +-- >> lib/Sema/SemaLookup.cpp | 27 +++++++++++-------- >> lib/Sema/SemaOpenMP.cpp | 7 +++-- >> lib/Sema/SemaOverload.cpp | 23 +++++++++------- >> lib/Sema/SemaTemplate.cpp | 17 ++++++------ >> lib/Sema/SemaTemplateVariadic.cpp | 8 +++--- >> 21 files changed, 179 insertions(+), 175 deletions(-) >> >> >> _______________________________________________ >> cfe-commits mailing list >> [email protected] >> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits >> >> >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
