Hal, thank you for the suggestion! I've expanded that comment four-fold in r214183.
Ted, thank you for reviewing the original patch, and no worries it took a while. You might want to also check that the comments I've added when committing r214064 are correct -- although they're essentially a rephrasing of comments from your own emails. -----Original Message----- From: Hal Finkel [mailto:[email protected]] Sent: 28 July 2014 13:12 To: Artyom Skrobov Cc: [email protected] Subject: Re: r214064 - Factoring DataflowWorklist out of LiveVariables and UninitializedValues analyses We should have a description here of what this code does, not just where it's used. One can get some idea by reading the comments above DataflowWorklist::enqueueSuccessors in the source file, but it is not clear that gives a complete picture. -Hal _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
