Committed in r214333. On Jul 30, 2014, at 11:52 AM, Aaron Ballman <[email protected]> wrote:
> On Wed, Jul 30, 2014 at 1:33 PM, Tyler Nowicki <[email protected]> wrote: >> Hi Aaron, >> >> Thanks for the review! Here is the updated patch and responses to some of >> your comments. The new tests are a couple of lines added to >> test/Parser/pragma-loop.cpp. This patch is just refactoring in preparation >> for new features so there really isn’t a need for new tests. > > I only mentioned the tests because your original email had said "A > couple of new tests are included as well." But the latest patch has > your updated test, so I'm all set there. Oops, sorry must have missed them in the first patch. > Your changes LGTM! If you want to change the comment discussed above, > that's cool, but it's certainly not holding back the patch. > > ~Aaron
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
