The code change seems reasonable if the flexibility of a callback is needed. I 
have no opinion on whether it is.

Do you have the followup change where this is used?

================
Comment at: include/clang/Driver/Multilib.h:158
@@ -152,1 +157,3 @@
 
+  MultilibSet &includeDirsCallback(IncludeDirsFunc F) {
+    IncludeCallback = F;
----------------
setincludeDirsCallback would be the correct name, no?

http://reviews.llvm.org/D4720



_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to